fix(entities): correct typing for selectActiveEntity #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
I am not sure if there should be a documentation update to accompany this.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
selectActiveEntity
operator is typed such that the resulting observable appears to only ever emit an entity.Issue Number: N/A
What is the new behavior?
The typing now reflects that the resulting observable can also emit undefined if there is no active entity or if the active ID doesn't match an entity in the store.
Does this PR introduce a breaking change?
There is no breaking actual behavior change, but projects using
selectActiveEntity
could have broken builds due to the more correct typing information, especially projects that are more strict in their compilation.Other information