Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirtyCheckGuard trigger confirmChanges on undefined isDirty$ #38

Open
remi-bouguermouh-eaton opened this issue Mar 29, 2023 · 0 comments

Comments

@remi-bouguermouh-eaton
Copy link

remi-bouguermouh-eaton commented Mar 29, 2023


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

When guard is put on a route and a component without isDirty$ implementation the guard triggers the confirmChanges method. I'm not sure if this is a desired behavior.

Minimal reproduction of the problem with instructions

Put the Guard on a route with a component that doesn't implement the isDirty$ property.

What is the motivation / use case for changing the behavior?

It would make sense to not have the confirmChanges triggers.

I can put a proposal if needed.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant