Fix Check for Updates button #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the interim, could cactbot have a Cactbot.ILogger type that is ILogger that would keep this working from the cactbot side until this lands? |
|
I don't think it will, because of the way it's looking for the constructor as far as I understand it. It'll only match the exact interface specified, so cactbot would have to switch back to the extended ILogger interface and we'd be back to square one/the chicken and egg problem we have here. Maybe there's a different way to target the constructor in question, but as I stated above, I'm not very familiar with C# reflection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263.
Probably there's a better way to do this but I'm not very familiar with C# reflection code, so I just went with what worked.