Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the latest version with older versions of NGINX Plus #629

Open
lucacome opened this issue Feb 8, 2024 · 6 comments
Open

Allow using the latest version with older versions of NGINX Plus #629

lucacome opened this issue Feb 8, 2024 · 6 comments
Labels
help wanted Issues identified as good community contribution opportunities refined Issues that are ready to be prioritized
Milestone

Comments

@lucacome
Copy link
Member

lucacome commented Feb 8, 2024

I want to be able to use the exporter with older versions of NGINX Plus and not have the latest version of the API hardcoded.

Depends on nginxinc/nginx-plus-go-client#222

@lucacome lucacome added this to the v1.2.0 milestone Feb 8, 2024
@lucacome lucacome changed the title Allow using the latest version with older version of NGINX Plus Allow using the latest version with older versions of NGINX Plus Feb 8, 2024

This comment was marked as outdated.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label May 8, 2024

This comment was marked as outdated.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
@lucacome lucacome reopened this Jun 20, 2024
@lucacome lucacome removed the stale Pull requests/issues with no activity label Jun 20, 2024
@lucacome lucacome modified the milestones: v1.2.0, v1.3.0, v1.4.0 Jul 16, 2024
@alitoufighi
Copy link

My assumption is we won't be able to fix this with the given solution for nginxinc/nginx-plus-go-client#222 as it needs an already connected client.

@lucacome
Copy link
Member Author

lucacome commented Aug 9, 2024

@alitoufighi yes we need a connection to get the API versions from NGINX. One of the options that I was thinking about was to check the version every time we collect the metrics, but that might be a little bit expensive.

I'm open to suggestions 🙂

@alitoufighi
Copy link

alitoufighi commented Aug 9, 2024

Hmm maybe beginning the connection in a minimal way (is finding the lowest compatible api version any easier? i.e. 1?) and then promoting it to a higher version? (I mean in the client)

Also I don't think the call to get API versions is over a specific API version, so it could be doable to communicate over to find the max compatible API version during initialization as well (in the nginx client repo, could be a breaking change?). It might not be the cleanest way either. (might actually give this a shot)

@mpstefan mpstefan added the blocked Issues that are blocked by external factors label Aug 14, 2024
@mpstefan
Copy link

mpstefan commented Aug 14, 2024

Blocked until nginx-plus-go-client 1.3.0 is released. When it is, @alitoufighi would you be open to creating a PR for this?

@lucacome lucacome removed the blocked Issues that are blocked by external factors label Aug 15, 2024
@mpstefan mpstefan added refined Issues that are ready to be prioritized help wanted Issues identified as good community contribution opportunities labels Aug 28, 2024
@mpstefan mpstefan added waiting for response Waiting for author's response and removed waiting for response Waiting for author's response labels Sep 11, 2024
@mpstefan mpstefan added backlog Pull requests/issues that are backlog items and removed backlog Pull requests/issues that are backlog items labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues identified as good community contribution opportunities refined Issues that are ready to be prioritized
Projects
None yet
Development

No branches or pull requests

3 participants