Skip to content

Add support for /processes and export functions #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2020
Merged

Add support for /processes and export functions #41

merged 1 commit into from
Jun 1, 2020

Conversation

@framer777
Copy link
Contributor

@framer777 framer777 commented Jun 1, 2020 •
edited
Loading

Proposed changes

  • Adding support for /processes API endpoint so we can monitor the count of respawned processes.

  • Export Get-from-API functions

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@framer777 framer777 added the enhancement Pull requests for new features/feature enhancements label Jun 1, 2020
@framer777 framer777 changed the title Add proc and subset Add support for /processes and subset of stats function Jun 1, 2020
@framer777 framer777 force-pushed the add-proc-and-subset branch from 5b8fe24 to 602742e Compare June 1, 2020 22:11
@framer777 framer777 changed the title Add support for /processes and subset of stats function Add support for /processes and export functions Jun 1, 2020
pleshakov
pleshakov suggested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@framer777 looks good!
just a consistency issue and missing doc string. Could you possibly address them?

@framer777 framer777 force-pushed the add-proc-and-subset branch from 602742e to 2f64441 Compare June 1, 2020 23:16
lucacome
lucacome approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@framer777 framer777 merged commit e11aefd into master Jun 1, 2020
@framer777 framer777 deleted the add-proc-and-subset branch June 1, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rulox Rulox Awaiting requested review from Rulox

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

2 more reviewers

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@framer777 @lucacome @pleshakov