-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate manifests using Helm #911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Jul 26, 2023
lucacome
reviewed
Jul 26, 2023
pleshakov
suggested changes
Jul 26, 2023
kate-osborn
requested changes
Jul 26, 2023
ciarams87
force-pushed
the
feat/simplify-manifests
branch
from
July 27, 2023 10:43
91f64d7
to
b3dbca2
Compare
pleshakov
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
kate-osborn
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
pleshakov
approved these changes
Aug 1, 2023
sjberman
reviewed
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a potential user of NKG
I want the manifest files simplified in the deployment manifests folder in the NKG repo
So that when I install NKG using manifests, I am not hindered by the need to evaluate each manifest file to see what is relevant to deploy for my environment.
Additionally, now that we have Helm templates, we have multiple deployment manifests/ templates requiring maintenance. This carries the risk of one of the deployment methods becoming out-of-sync with the other.
Solution: Generate the deployment manifests from the Helm templates, simplifying maintenance, and reducing the required steps a user needs to undertake to deploy NKG using manifests. This also has the effect that labels and selectors are consistent across the Helm templates and the manifests.
This solution does not include the
Service
manifest in the main manifest yaml as this is environment specific. However, theService
manifests are also generated from the Helm templates.Additionally, the static deployment manifest for the provisioner is also being generated, and has been moved to the
conformance/provisioner
folder with the provisioner yaml.Testing: Manual installs using Helm and the new manifests, and ensuring the conformance tests can still run and pass
Closes #780
Checklist
Before creating a PR, run through this checklist and mark each as complete.