Refactor webhook validation #510
Merged
+737
−485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
commented
Mar 28, 2023
pleshakov
force-pushed
the
chore/refactor-webhook-validation
branch
2 times, most recently
from
a381fed to
5aa8070
Compare
kate-osborn
reviewed
Mar 29, 2023
- Move webhook validation code to the state package so that the package is responsible for enforcing it. As a result, it will not need require the users of that package to validate the supplied Gateway API resources, which will make it easier to use the package and reduce the number of possible bugs. Fixes #416 - Fix Webhook Validation is bypassed for existing resources when NKG starts. Fixes #433
pleshakov
force-pushed
the
chore/refactor-webhook-validation
branch
from
5aa8070 to
183ed5d
Compare
kate-osborn
suggested changes
Apr 3, 2023
kate-osborn
approved these changes
Apr 4, 2023
pleshakov
changed the title
pleshakov
added
tech-debt
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
- Move webhook validation code to the state package so that the package is responsible for enforcing it. As a result, it will not need require the users of that package to validate the supplied Gateway API resources, which will make it easier to use the package and reduce the number of possible bugs. Fixes nginx#416 - Fix Webhook Validation is bypassed for existing resources when NKG starts. Fixes nginx#433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Webhook validation code
is responsible for enforcing it. As a result, it will not need require
the users of that package to validate the supplied Gateway API
resources, which will make it easier to use the package and reduce
the number of possible bugs. Fixes
Refactor Webhook validation code #416
starts. Fixes
Webhook Validation is bypassed for existing resources when NKG starts #433