Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yamllint action from reviewdog #2186

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Use yamllint action from reviewdog #2186

merged 3 commits into from
Jul 2, 2024

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Jul 1, 2024 •
edited
Loading

Proposed changes

Problem: We manually install yamnllint without controlling the version

Solution: Use an action-yamllint so we can pin the version and also get annotations

Closes #2185

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome
Use yamllint action from reviewdog
f903da8 
Problem: We manually install yamnllint without controlling the version

Solution: Use an action-yamllint so we can pin the version and also get
annotations
@lucacome lucacome requested a review from a team as a code owner July 1, 2024 19:55
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 1, 2024
@lucacome lucacome enabled auto-merge (squash) July 1, 2024 22:23
salonichf5
salonichf5 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucacome lucacome merged commit 92661af into nginx:main Jul 2, 2024
37 checks passed
@lucacome lucacome deleted the chore/yamllint branch July 2, 2024 21:49
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Use yamllint action from reviewdog (nginx#2186)
c11fe2a 
Problem: We manually install yamnllint without controlling the version

Solution: Use an action-yamllint so we can pin the version and also get
annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@bjee19 bjee19 bjee19 approved these changes

@salonichf5 salonichf5 salonichf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Pinned-Dependencies
4 participants
@lucacome @sjberman @bjee19 @salonichf5