-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event batch processing results and rerun reconfig test #1186
Conversation
Note the quite big changes in results of the TimeToReadyTotal and TimeToReadyAvgSingle, I checked with @ciarams87 with a couple of them and she said that they seemed reasonable. What do you all think? |
The big deviation is mostly in test 2. I believe this expected behaviour after the status updater improvements (only updating the status when there is a change). My understanding is that there are actually less changes being processed, which then leads to more efficient handling of each individual resource update. This means we are doing less batching (that is, there are less items being added to each batch), and therefore calling a reload for almost every config change. Because we are reloading more, I think this is leading to the increased TTR. Unfortunately we don't have the event batch processing results from the first round, but I checked the logs from the run and there are less batches with more resources in each (cumulatively increasing with each batch) and correspondingly less reloads. The largest batch resulting in a config change in the old runs logs was 310. Does that make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
78a78bf
to
a4c92e1
Compare
Add event batch processing metrics to reconfiguration test and rerun the test. Added some clarification and other small adjustments to test. Problem: We already measured how long it took for NGINX to reload, but didn't measure for how long it took for NGF to update statuses of a resource. Solution: Add event batch processing metrics to test.
Add event batch processing metrics to reconfiguration test and rerun the test. Added some clarification and other small adjustments to test. Problem: We already measured how long it took for NGINX to reload, but didn't measure for how long it took for NGF to update statuses of a resource. Solution: Add event batch processing metrics to test.
Proposed changes
Add event batch processing metrics to reconfiguration test and rerun the test. Added some clarification and other small adjustments to test.
Problem: We already measured how long it took for NGINX to reload, but didn't measure for how long it took for NGF to update statuses of a resource.
Solution: Add event batch processing metrics to test.
Testing: Reran the manual test.
Closes #1127
Checklist
Before creating a PR, run through this checklist and mark each as complete.