Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Plane Dynamic Configuration #929

Closed
mpstefan opened this issue Aug 2, 2023 · 4 comments · Fixed by #1215
Closed

Data Plane Dynamic Configuration #929

mpstefan opened this issue Aug 2, 2023 · 4 comments · Fixed by #1215
Assignees
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Milestone

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Aug 2, 2023

Is your enhancement request related to a problem? Please describe.
The NKG data plane will not have a method to manage configuration once the project has a custom nginx container. The NKG project needs a method to configure the data plane outside of the ConfigMap that exists today. Ideally, this configuration should be dynamic and any changes should prompt the data plane to change based on its contents.

What would you like to be added:
A method to dynamically update NKG data plane settings and initial options to configure tracing for NGF and upstream zone size.

Why this is needed:
So users have a method configure the nginx data plane without breaking NKG functionality.

Additional context
Discussion

@mpstefan mpstefan added the enhancement New feature or request label Aug 2, 2023
@mpstefan mpstefan added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Aug 23, 2023
@sjberman
Copy link
Contributor

sjberman commented Oct 19, 2023

The initial version of this should be for supporting tracing configuration.

An initial proposal draft was written up here: #931, though was not focused specifically on tracing.

https://github.com/nginxinc/nginx-gateway-fabric/blob/main/docs/proposals/control-plane-config.md can also be used as a reference.

@mpstefan mpstefan removed the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Oct 23, 2023
@mpstefan mpstefan added this to the v1.1.0 milestone Oct 23, 2023
@mpstefan
Copy link
Collaborator Author

Does the initial proposal need to be updated to include tracing configuration as the first configurable option? The proposal will need to be moved to implementable before design can begin.

@sjberman
Copy link
Contributor

I'd say we can start with tracing.

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Oct 24, 2023
@sjberman sjberman self-assigned this Oct 31, 2023
@sjberman sjberman moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Oct 31, 2023
@sjberman sjberman moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Nov 1, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Nov 3, 2023
@mpstefan
Copy link
Collaborator Author

mpstefan commented Feb 2, 2024

Closed as not planned due to our change in strategy for changes in data plane configuration. See #1258

@mpstefan mpstefan closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants