Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Recommended NGINX Default Configuration #557

Closed
ja20222 opened this issue Apr 5, 2023 · 0 comments · Fixed by #1040
Closed

Define Recommended NGINX Default Configuration #557

ja20222 opened this issue Apr 5, 2023 · 0 comments · Fixed by #1040
Assignees
@sjberman
Labels
area/nginx-configuration Relates to nginx configuration enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Milestone
v1.0.0

Comments

@ja20222
Copy link

ja20222 commented Apr 5, 2023 •
edited by mpstefan
Loading

As a user of NKG
I want the NKG configuration to be defaulted to a set of configuration that will likely work best for me
So that I do not need to tweak configuration every time I install NKG.

Acceptance

  • Compare NKG base NGINX config with NIC and implement changes to reduce performance, stability, security, and interoperability issues before launch. For example:
    • enable keepalives to backends by default
    • set common headers when proxying
  • Review base NGINX configuration with NGINX experts for feedback.
@pleshakov pleshakov added this to the v1.0.0 milestone Apr 7, 2023
@pleshakov pleshakov added the area/nginx-configuration Relates to nginx configuration label Apr 7, 2023
@pleshakov pleshakov changed the title Better NGINX configuration: enable keepalives to backends by default Spike: Harden NGINX configuration Apr 7, 2023
@mpstefan mpstefan changed the title Spike: Harden NGINX configuration Define Recommended NGINX Default Configuration Jun 9, 2023
@mpstefan mpstefan added the enhancement New feature or request label Jun 9, 2023
@mpstefan mpstefan modified the milestones: v1.0.0, v1.0.1 Aug 11, 2023
@mpstefan mpstefan added good first issue Good for newcomers refined Requirements are refined and the issue is ready to be implemented. labels Aug 21, 2023
@mpstefan mpstefan modified the milestones: v1.0.1, v1.0.0 Aug 21, 2023
@mpstefan mpstefan added size/medium Estimated to be completed within a week and removed good first issue Good for newcomers labels Aug 21, 2023
@sjberman sjberman self-assigned this Sep 5, 2023
@sjberman sjberman moved this from 🆕 New to 🔖 To Do in NGINX Gateway Fabric Sep 5, 2023
@sjberman sjberman moved this from 🔖 To Do to 🏗 In Progress in NGINX Gateway Fabric Sep 5, 2023
@ciarams87 ciarams87 mentioned this issue Sep 6, 2023
Merged
6 tasks
@sjberman sjberman mentioned this issue Sep 6, 2023
Merged
6 tasks
@sjberman sjberman moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Sep 6, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
area/nginx-configuration Relates to nginx configuration enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Optimize default nginx config sjberman/nginx-gateway-fabric
4 participants
@pleshakov @mpstefan @sjberman @ja20222