Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error updating status of gateway resource in NFR Scale test HTTPSListeners #2562

Closed
bjee19 opened this issue Sep 16, 2024 · 1 comment
Closed

Comments

@bjee19
Copy link
Contributor

bjee19 commented Sep 16, 2024

In this pipeline run of the NFR test results on edge: https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/10872403318, the scale test for HTTPSListeners encountered an error when ran on OSS.

Shown Error:

{
  "level": "debug",
  "ts": "2024-09-15T17:08:33Z",
  "logger": "statusUpdater",
  "msg": "Encountered error updating status",
  "error": "Operation cannot be fulfilled on gateways.gateway.networking.k8s.io \"gateway\": the object has been modified; please apply your changes to the latest version and try again",
  "namespace": "scale",
  "name": "gateway",
  "kind": "Gateway"
}

The full NFR test results can be found in this PR: #2554

@kate-osborn
Copy link
Contributor

After some investigation, this does not appear to be a product bug. We retry on status update failures because the object may be modified between fetching the object and writing its status. On each retry, we fetch the latest version of the object. If multiple retries fail, we will log an error message saying, "Failed to update status." Since the logs do not contain that error message, we can assume that the status update eventually succeeded.

If this error persists in our NFR tests, we should look into the test code and see if we can prevent this situation from occurring. Perhaps we can wait for an object's status to update before modifying the object's spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants