Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify HTTPRoute rule can have up to 64 matches #2431

Open
kate-osborn opened this issue Aug 20, 2024 · 1 comment
Open

Verify HTTPRoute rule can have up to 64 matches #2431

kate-osborn opened this issue Aug 20, 2024 · 1 comment
Assignees
@salonichf5
Labels
blocked Blocked by other issue chore Pull requests for routine tasks refined Requirements are refined and the issue is ready to be implemented. size/extra-small Estimated to be completed within a day
Milestone
v1.5.0

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Aug 20, 2024 •
edited by mpstefan
Loading

Recently, a change was merged that increases the limit on the number of matches in a rule to 64 from 8. However, the total number of matches across all rules in a route remains limited to 128.

As part of this change, the CEL rules for HTTPRoute have been updated to enforce these limitations. However, we need to check that NGF can support rules with up to 64 matches.

A/C:

  • Manually create an HTTPRoute with a rule with 64 matches and make sure the route is accepted and configured properly.

Note: in order to test, we will have to install the latest version of the Gateway API CRDS (ref=main)
@kate-osborn kate-osborn mentioned this issue Aug 20, 2024
Closed
@mpstefan mpstefan added this to the v1.5.0 milestone Aug 27, 2024
@mpstefan mpstefan added the chore Pull requests for routine tasks label Aug 27, 2024
@sjberman sjberman mentioned this issue Oct 4, 2024
Closed
1 task
@mpstefan
Copy link
Collaborator

mpstefan commented Oct 7, 2024

Blocked by #2656

@mpstefan mpstefan added blocked Blocked by other issue refined Requirements are refined and the issue is ready to be implemented. size/extra-small Estimated to be completed within a day labels Oct 7, 2024
@salonichf5 salonichf5 self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salonichf5 salonichf5

Labels
blocked Blocked by other issue chore Pull requests for routine tasks refined Requirements are refined and the issue is ready to be implemented. size/extra-small Estimated to be completed within a day
Projects
NGINX Gateway Fabric
Status: 🏗 In Progress
Milestone
v1.5.0
Development

No branches or pull requests
3 participants
@mpstefan @kate-osborn @salonichf5