Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect link in developer docs #2187

Closed
salonichf5 opened this issue Jul 2, 2024 · 3 comments · Fixed by #2141
Closed

Incorrect link in developer docs #2187

salonichf5 opened this issue Jul 2, 2024 · 3 comments · Fixed by #2141
Assignees
Labels
bug Something isn't working

Comments

@salonichf5
Copy link
Contributor

salonichf5 commented Jul 2, 2024

Describe the bug
Link to update documentation for developers has the wrong link

To Reproduce
Steps to reproduce the behavior:

  1. Go to docs Implementing a Feature
  2. Open documentation link on bullet point 10.
  3. Leads to page not found.

Expected behavior
Documentation Link is updated correctly

Your environment

  • Version of the NGINX Gateway Fabric - v1.3
  • Version of Kubernetes
  • Kubernetes platform (e.g. Mini-kube or GCP)
  • Details on how you expose the NGINX Gateway Fabric Pod (e.g. Service of type LoadBalancer or port-forward)
  • Logs of NGINX container: kubectl -n nginx-gateway logs -l app=nginx-gateway -c nginx
  • NGINX Configuration: kubectl -n nginx-gateway exec <gateway-pod> -c nginx -- nginx -T

Additional context
Add any other context about the problem here. Any log files you want to share.

@salonichf5
Copy link
Contributor Author

I can make this change in my Troubleshooting guide PR if its alright? Very small change. @sjberman @kate-osborn @pleshakov

@bjee19
Copy link
Contributor

bjee19 commented Jul 2, 2024

Could also be a good option to open a quick fix so it can go in asap w/o going in with a larger PR still under review.

@salonichf5 salonichf5 self-assigned this Jul 2, 2024
@salonichf5 salonichf5 added the bug Something isn't working label Jul 2, 2024
@salonichf5
Copy link
Contributor Author

salonichf5 commented Jul 2, 2024

Could also be a good option to open a quick fix so it can go in asap w/o going in with a larger PR still under review.

The PR has approvals and is waiting for a another pass through so should go in soon.

@salonichf5 salonichf5 moved this from 🆕 New to 👀 In Review in NGINX Gateway Fabric Jul 3, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants