Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGF is reloading NGINX for BackendTLSPolicy with no accepted Gateway #1577

Open
Tracked by #1664
ciarams87 opened this issue Feb 14, 2024 · 1 comment
Open
Tracked by #1664
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working

Comments

@ciarams87
Copy link
Member

Describe the bug
We are reloading after reconciling a BackendTLSPolicy even when there is no Gateway. This is because we treat every upsert/delete of a BackendTLSPolicy as a change. This means we will regenerate nginx config every time a BackendTLSPolicy is created, updated (generation must change), or deleted, even if it does not apply to the accepted Gateway.

To Reproduce
Deploy a BackendTLSPolicy with no Gateway.

Expected behavior
Config should not be rewritten and NGINX should not be reloaded when no NGINX config changes have occurred.

See: #1487

Copy link
Contributor

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Feb 29, 2024
@ciarams87 ciarams87 removed the stale Pull requests/issues with no activity label Feb 29, 2024
@mpstefan mpstefan added the bug Something isn't working label Mar 11, 2024
@mpstefan mpstefan modified the milestone: v1.3.0 Mar 11, 2024
@mpstefan mpstefan added area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants