Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGF is reloading NGINX for ReferenceGrants with no accepted Gateway #1124

Open
Tracked by #1664
ciarams87 opened this issue Oct 10, 2023 · 0 comments
Open
Tracked by #1664

NGF is reloading NGINX for ReferenceGrants with no accepted Gateway #1124

ciarams87 opened this issue Oct 10, 2023 · 0 comments
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working good first issue Good for newcomers

Comments

@ciarams87
Copy link
Member

Describe the bug
We are reloading after reconciling a ReferenceGrant even when there is no Gateway. This is because we treat every upsert/delete of a ReferenceGrant as a change. This means we will regenerate nginx config every time a ReferenceGrant is created, updated (generation must change), or deleted, even if it does not apply to the accepted Gateway.

To Reproduce
Deploy a ReferenceGrant with no Gateway.

Expected behavior
Config should not be rewritten and NGINX should not be reloaded when no NGINX config changes have occurred.

Your environment
GKE cluster:

  • Node count: 3
  • Instance Type: e2-medium
  • k8s version: 1.27.4-gke.900
  • Zone: europe-west2-b
  • Total vCPUs: 6
  • Total RAM: 12GB
  • Max pods per node: 110

NGF deployment:

  • NGF version: edge - git commit 72b6c6e
  • NGINX Version: 1.25.2

Additional context
See #1116

@ja20222 ja20222 added area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working labels Nov 21, 2023
@kate-osborn kate-osborn added temp good first issue Good for newcomers and removed temp labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working good first issue Good for newcomers
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants