NGF is reloading NGINX for ReferenceGrants with no accepted Gateway #1124
Labels
area/performance
Performance related
backlog
Currently unprioritized work. May change with user feedback or as the product progresses.
bug
Something isn't working
good first issue
Good for newcomers
Describe the bug
We are reloading after reconciling a ReferenceGrant even when there is no Gateway. This is because we treat every upsert/delete of a ReferenceGrant as a change. This means we will regenerate nginx config every time a ReferenceGrant is created, updated (generation must change), or deleted, even if it does not apply to the accepted Gateway.
To Reproduce
Deploy a ReferenceGrant with no Gateway.
Expected behavior
Config should not be rewritten and NGINX should not be reloaded when no NGINX config changes have occurred.
Your environment
GKE cluster:
NGF deployment:
Additional context
See #1116
The text was updated successfully, but these errors were encountered: