Skip to content

Commit c5f8dbe

Browse files
authored
Add retries to tracing tests (#2101)
Problem: The tracing tests are still flaky as to whether or not the traces properly show up. The issues isn't really know right now. Solution: Add retries to the test in an attempt to remediate the intermittent issue.
1 parent 23f75a4 commit c5f8dbe

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tests/suite/tracing_test.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ import (
2323
"github.com/nginxinc/nginx-gateway-fabric/tests/framework"
2424
)
2525

26-
var _ = Describe("Tracing", Label("functional", "tracing"), func() {
26+
// This test can be flaky when waiting to see traces show up in the collector logs.
27+
// Sometimes they get there right away, sometimes it takes 30 seconds. Retries were
28+
// added to attempt to mitigate the issue, but it didn't fix it 100%
29+
var _ = Describe("Tracing", FlakeAttempts(2), Label("functional", "tracing"), func() {
2730
var (
2831
files = []string{
2932
"hello-world/apps.yaml",

0 commit comments

Comments
 (0)