Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update aws deployment docs with helm instructions #6457

Merged
merged 8 commits into from
Sep 19, 2024
Merged

update aws deployment docs with helm instructions #6457

merged 8 commits into from
Sep 19, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Sep 18, 2024 •
edited
Loading

Proposed changes

Update the AWS documentation to include how to deploy using helm

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners September 18, 2024 16:17
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 18, 2024
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6457/

@pdabelf5
Copy link
Collaborator Author

@ADubhlaoich the Tip: no longer seems to render correctly in {{tab}}. Is there anything to do to help this?

ADubhlaoich
ADubhlaoich approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small formatting nitpicks with low LOGAF.

@pdabelf5 pdabelf5 enabled auto-merge (squash) September 19, 2024 12:45
@pdabelf5 pdabelf5 merged commit 6bd9c4b into main Sep 19, 2024
30 checks passed
@pdabelf5 pdabelf5 deleted the aws-mktpl-helm branch September 19, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdabelf5 @ADubhlaoich @j1m-ryan @vepatel @jjngx