Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plain Markdown callouts to Hugo callouts #6038

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Update plain Markdown callouts to Hugo callouts #6038

merged 3 commits into from
Jul 24, 2024

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jul 18, 2024 •
edited
Loading

Proposed changes

This commit updates instance of plain Markdown callouts ("> Text") to instead use a Hugo callout, which are more visually distinct from text on a page. This is more consistent across the documentation set.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ADubhlaoich
Update plain Markdown callouts to Hugo callouts
b238654 
This commit updates instance of plain Markdown callouts ("> Text") to
instead use a Hugo callout, which are more visually distinct from text
on a page. This is more consistent across the documentation set.
@ADubhlaoich ADubhlaoich requested review from a team as code owners July 18, 2024 15:29
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 18, 2024
@ADubhlaoich ADubhlaoich self-assigned this Jul 18, 2024
@ADubhlaoich ADubhlaoich merged commit ae0a1e9 into main Jul 24, 2024
52 checks passed
@ADubhlaoich ADubhlaoich deleted the fix-callouts branch July 24, 2024 11:49
ADubhlaoich added a commit that referenced this pull request Aug 23, 2024
@ADubhlaoich
Update plain Markdown callouts to Hugo callouts (#6038)
6607252 
This commit updates instance of plain Markdown callouts ("> Text") to
instead use a Hugo callout, which are more visually distinct from text
on a page. This is more consistent across the documentation set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees

@ADubhlaoich ADubhlaoich

Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ADubhlaoich @vepatel @pdabelf5