Update nginx-opentracing and jaeger-client-cpp #1883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker opentracing build stage does not yield working image due to the Opentracing library version mismatch. Update Nginx Opentracing library from 0.10.0 to the latest available version of 0.19.0. Change also requires higher version of Jaeger Tracing module which can't be just downloaded (last available download is v0.4.2) and therefore build Jaeger Tracing module v0.7.0 as part of the opentracing-builder stage. Keep the plus version untouched.
|
Hi @MatyRi, Thanks for creating this change, we'll take a look and review it as soon as we can. Sean |
soneillf5
approved these changes
Aug 23, 2021
ciarams87
approved these changes
Aug 23, 2021
lucacome
reviewed
Aug 23, 2021
Co-authored-by: Luca Comellini <[email protected]>
lucacome
changed the title
ciarams87
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Docker opentracing build stage does not yield working image due to the Opentracing library version mismatch. This change updates Nginx Opentracing library from 0.10.0 to the latest available version of 0.19.0.
It also requires higher version of Jaeger Tracing module which can't be just downloaded (last available download is v0.4.2) and therefore Jaeger Tracing module v0.7.0 is now built as part of the opentracing-builder stage. Latest Jaeger Tracing also has a dependency on libyaml libraries which are copied during the final build stage.
Changes just affect the Open Source version of Nginx Ingress
It seems the smoke tests in Github pipeline do not test the actual loading of the opentracing library in nginx config. It would be great to add this to the tests as well but I don't know how to do that right now, so I'm just sharing these changes which I tested.
Changes in the Dockerfile reflect the build steps in here: https://github.com/opentracing-contrib/nginx-opentracing/blob/master/Dockerfile
Checklist