Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ingress and IngressClass v1 #1850

Merged
merged 5 commits into from
Aug 12, 2021
Merged

Conversation

pleshakov
Copy link
Contributor

Proposed changes

  • Use Ingress v1 in the code
  • Reject Ingresses with resource backends, because the IC doesn't support such backends:
          - path: /icons
            pathType: ImplementationSpecific
            backend:
              resource:
                apiGroup: k8s.example.com
                kind: StorageBucket
                name: icon-assets
  • Use IngressClass v1 in the code
  • Remove k8s < 1.19 from nightly

Note: the existing tests work for k8s 1.19-1.21
in a separate PR we will update the tests so that they work for k8s 1.19-1.22

The PR doesn't change the minimum supported k8s version for the IC - that will be done separately.
The PR doesn't update any docs - that will be done separately.

@pleshakov pleshakov added the change Pull requests that introduce a change label Aug 11, 2021
@pleshakov
Copy link
Contributor Author

(forced pushed to remove linting errors)

@soneillf5 soneillf5 force-pushed the support-v1-for-ic-and-ing branch 2 times, most recently from 8bd5c01 to ea66f6d Compare August 12, 2021 15:09
@pleshakov pleshakov requested a review from vepatel August 12, 2021 15:31
.github/workflows/nightly.yml Show resolved Hide resolved
@pleshakov pleshakov merged commit d05a025 into master Aug 12, 2021
@pleshakov pleshakov deleted the support-v1-for-ic-and-ing branch August 12, 2021 18:45
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Sep 13, 2021
@pleshakov pleshakov changed the title Support Ingress and Ingress class v1 Support Ingress and IngressClass v1 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Pull requests that introduce a change enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants