Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for missing image, docs Makefile, and netlify build commands #1764

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Jul 16, 2021

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

  • This PR restores a missing image to the How NIC Works doc:
    image
  • fixes the path used in the docs Makefile when running the hugo server locally
  • fixes the netlify build command for deploy previews and branch deploys

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug documentation Pull requests/issues for documentation labels Jul 16, 2021
@jputrino jputrino changed the title fix for missing image fix for missing image, docs Makefile, and netlify build commands Jul 16, 2021
@jputrino jputrino requested review from lucacome and pleshakov July 16, 2021 18:11
@jputrino jputrino merged commit 651712c into master Jul 16, 2021
@jputrino jputrino deleted the staging branch July 16, 2021 20:38
@jputrino jputrino restored the staging branch July 16, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants