Change policy update handler to only reload on spec change #1713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
At the moment, the update handler for Policy resources uses a 'DeepEquals()' for comparing the old and new Policy, however the scope fo which is too broad, so minor changes such as resource version and status result in an Nginx reload.
This change compares just the 'Spec' of each Policy, so it only causes a reload if config data changes.
Checklist
Before creating a PR, run through this checklist and mark each as complete.