Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in TS health check #1417

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

LorcanMcVeigh
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh commented Mar 1, 2021

Proposed changes

This PR addresses a bug in the default values from health checks in transport server and refactors name of Interval field in yaml to be the same as in VS and VSR

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@LorcanMcVeigh LorcanMcVeigh self-assigned this Mar 1, 2021
@github-actions github-actions bot added the bug An issue reporting a potential bug label Mar 1, 2021
@LorcanMcVeigh LorcanMcVeigh merged commit 7c665c8 into master Mar 1, 2021
@LorcanMcVeigh LorcanMcVeigh deleted the fix-ts-health0check0defaults branch March 1, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants