Enable CORS

[g3gurung]

I have successfully added

annotations:
    nginx.org/client-max-body-size: "10m"

and I tried to use cors by adding another annotation like this but it is not working
ingress.kubernetes.io/enable-cors: "true"

Is there some other way to enable cors!

[pleshakov]

@g3gurung
unfortunately, the enable-cors annotation is not supported. However, I can suggest a few possible solutions:

• Adding the neccesary headers directly to the template -- https://github.com/nginxinc/kubernetes-ingress/blob/master/nginx-controller/nginx/ingress.tmpl -- and building your own image
• Adding the neccessary headers using the nginx.org/location-snippets annotation, as described here Add template options #117 . This features is not available in our DockerHub image yet, so to use it please build you own image using the latest sources.
• Extending the controller by adding the annotation that will add those headers. Here is an example of adding an annotation with similar logic -- Add support for 301 redirect to https #116

[cheddarwhizzy]

I'm adding support for CORS. I hope to create a Pull Request this week. The annotations I'm creating are 'nginx.org/cors-domains' and 'nginx.org/cors-enabled'. If just cors-enabled is defined, it'll allow all "*" Origins. Defining 'cors-domains' will act as a domain whitelist. I was going to add this to the server block rather than the location block. We can change 'nginx.org' to 'ingress.kubernetes.io' if that's better.

Does this sounds like a good solution?

[pleshakov]

@bporter2387
That sounds good! Thanks!

It is important that all add_header directives are defined in the same level. For example, add_header directives defined in a location block overwrite any add_header directives in a server block.

nginx.org is better for now, as all other annotations are also nginx.org ones. We can add support for ingress.kubernetes.io annotations later, if we need to.

[cheddarwhizzy]

I created PR #144 . I added a 401 on non-whitelisted domains. Not sure if this ideal, but I noticed our upstream endpoints are still hit from non-whitelisted Origins unless I had this 401 in place. However, in browsers I still got the CORS error without the 401, so that's good.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.