Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a "build" image to support custom module development #239

Closed
AnthonyMastrean opened this issue Apr 9, 2018 · 4 comments
Closed

Comments

@AnthonyMastrean
Copy link

I'm just getting started with custom module development and I'm having a hard time getting the exact correct prerequisites and sources downloaded properly. Would it make sense to publish a "build" image Looks like it should be something like the first ~50 lines of this image, except without compiling and without cleaning up.

@AnthonyMastrean AnthonyMastrean changed the title Publish a "build" image? Publish a "build" image to support custom module development Apr 9, 2018
@thresheek
Copy link
Collaborator

All the prerequisites are in apt-get build-dep nginx.

Regarding the "build" image, it might make sense yes, if it includes:

PR are welcome!

@AnthonyMastrean
Copy link
Author

AnthonyMastrean commented May 3, 2018

Would you need a "build image" per distribution? I assume building modules from source would require building on the same distribution as the intended runtime.

What's the equivalent of apt-get build-dep nginx on Alpine w/ apk?

@thresheek
Copy link
Collaborator

You'd need the binaries to be compatible to the actual tag/nginx version you're building against, so indeed, you need to build on the same distribution. For apk, we've recently introduced nginx.org prebuilt packages, so you might want to re-use those to create new module packages. See http://hg.nginx.org/pkg-oss/file/tip/alpine for more details on that.

@thresheek
Copy link
Collaborator

Hi. I've added a way to make it easier to add modules on top of the official image, please check https://github.com/nginxinc/docker-nginx/tree/master/modules for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants