From 05fc55ab2b474d358004293071a3fe5e1f8d9cff Mon Sep 17 00:00:00 2001 From: Kate Osborn Date: Wed, 17 Aug 2022 14:36:12 -0600 Subject: [PATCH 1/2] Use edge tag in examples and makefile --- Makefile | 2 +- deploy/manifests/nginx-gateway.yaml | 2 +- docs/building-the-image.md | 6 +++--- docs/installation.md | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 3008f42dac..6a1d24da51 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,7 @@ PREFIX ?= nginx-kubernetes-gateway GIT_COMMIT = $(shell git rev-parse HEAD) DATE = $(shell date -u +"%Y-%m-%dT%H:%M:%SZ") -TARGET ?= local +TARGET ?= edge KIND_KUBE_CONFIG_FOLDER = $${HOME}/.kube/kind OUT_DIR=$(shell pwd)/build/.out diff --git a/deploy/manifests/nginx-gateway.yaml b/deploy/manifests/nginx-gateway.yaml index 97f69cf6e3..995961393a 100644 --- a/deploy/manifests/nginx-gateway.yaml +++ b/deploy/manifests/nginx-gateway.yaml @@ -86,7 +86,7 @@ spec: - name: nginx-config mountPath: /etc/nginx containers: - - image: nginx-kubernetes-gateway:0.0.1 + - image: nginx-kubernetes-gateway:edge imagePullPolicy: IfNotPresent name: nginx-gateway volumeMounts: diff --git a/docs/building-the-image.md b/docs/building-the-image.md index 2a99bb4776..6700e192bb 100644 --- a/docs/building-the-image.md +++ b/docs/building-the-image.md @@ -22,12 +22,12 @@ Before you can build the NGINX Kubernetes Gateway, make sure you have the follow make PREFIX=myregistry.example.com/nginx-kubernetes-gateway container ``` - Set the `PREFIX` variable to the name of the registry you'd like to push the image to. By default, the image will be named `nginx-kubernetes-gateway:0.0.1`. + Set the `PREFIX` variable to the name of the registry you'd like to push the image to. By default, the image will be named `nginx-kubernetes-gateway:edge`. 1. Push the image to your container registry: ``` - docker push myregistry.example.com/nginx-kubernetes-gateway:0.0.1 + docker push myregistry.example.com/nginx-kubernetes-gateway:edge ``` - Make sure to substitute `myregistry.example.com/nginx-kubernetes-gateway` with your registry. \ No newline at end of file + Make sure to substitute `myregistry.example.com/nginx-kubernetes-gateway` with your registry. diff --git a/docs/installation.md b/docs/installation.md index 377caf8169..6b2baa2fee 100644 --- a/docs/installation.md +++ b/docs/installation.md @@ -14,7 +14,7 @@ You can deploy NGINX Kubernetes Gateway on an existing Kubernetes 1.16+ cluster. 1. Load the NGINX Kubernetes Gateway image onto your kind cluster: ``` - kind load docker-image nginx-kubernetes-gateway:0.0.1 + kind load docker-image nginx-kubernetes-gateway:edge ``` Make sure to substitute the image name with the name of the image you built. @@ -107,4 +107,4 @@ Create a service with type `LoadBalancer` using the appropriate manifest for you ``` nslookup - ``` \ No newline at end of file + ``` From edab7ae9d567547fbfe13684761fa16f8793dae4 Mon Sep 17 00:00:00 2001 From: Kate Osborn Date: Thu, 18 Aug 2022 09:20:50 -0600 Subject: [PATCH 2/2] Version not target --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 6a1d24da51..ac3a193780 100644 --- a/Makefile +++ b/Makefile @@ -1,11 +1,11 @@ -VERSION = 0.0.1 +VERSION = edge TAG = $(VERSION) PREFIX ?= nginx-kubernetes-gateway GIT_COMMIT = $(shell git rev-parse HEAD) DATE = $(shell date -u +"%Y-%m-%dT%H:%M:%SZ") -TARGET ?= edge +TARGET ?= local KIND_KUBE_CONFIG_FOLDER = $${HOME}/.kube/kind OUT_DIR=$(shell pwd)/build/.out