Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest Graph to determine if a resource triggers a Graph rebuild #824

Closed
pleshakov opened this issue Jul 6, 2023 · 0 comments
Closed
Labels
tech-debt Short-term pain, long-term benefit
Milestone

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Jul 6, 2023

Currently, relationship.Capturer is used to determine if we need to process Namespace or Endpointslice resources

Because the Graph is a state of the Gateway API and relevant cluster resources, use it as a source to determine relevant Namespace or Endpointslice resources, rather than a separate component. This will avoid having duplicated logic to track relationship and make the Graph the source of truth.

See FIXME https://github.com/nginxinc/nginx-kubernetes-gateway/blob/36d5df4f5b047eadcbc2b814f19c216a054c2d6c/internal/state/graph/graph.go#L51

Acceptance criteria:

  • Use the Graph instead of relationship.Capturer
### Tasks
- [ ] https://github.com/nginxinc/nginx-gateway-fabric/issues/1263
- [ ] https://github.com/nginxinc/nginx-gateway-fabric/issues/1264
@pleshakov pleshakov added the tech-debt Short-term pain, long-term benefit label Jul 6, 2023
@pleshakov pleshakov mentioned this issue Jul 6, 2023
6 tasks
@mpstefan mpstefan added this to the v1.0.0 milestone Jul 12, 2023
@mpstefan mpstefan modified the milestones: v1.0.0, v1.0.1 Aug 11, 2023
@mpstefan mpstefan modified the milestones: v1.0.1, v1.2.0 Sep 22, 2023
@mpstefan mpstefan modified the milestones: v1.2.0, v1.3.0 Dec 11, 2023
@bjee19 bjee19 closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Short-term pain, long-term benefit
Projects
None yet
Development

No branches or pull requests

3 participants