Use proper internal GKE service annotation (#3431)

sjberman · sjberman · commit 4141c36bda4c · 2025-06-02T13:42:33.000-06:00
Problem: The service annotation for the GKE services was improperly formatted.

Solution: Fix the annotation so it provisions the proper service.
diff --git a/charts/nginx-gateway-fabric/values.yaml b/charts/nginx-gateway-fabric/values.yaml
@@ -493,7 +493,7 @@ gateways: []
 #   gatewayClassName: nginx
 #   infrastructure:
 #     annotations:
-#       service.annotations.networking.gke.io/load-balancer-type: Internal
+#       networking.gke.io/load-balancer-type: Internal
 #   listeners:
 #     - name: https
 #       port: 80
diff --git a/tests/suite/manifests/dp-perf/gateway.yaml b/tests/suite/manifests/dp-perf/gateway.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/longevity/gateway.yaml b/tests/suite/manifests/longevity/gateway.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/ngf-upgrade/gateway-updated.yaml b/tests/suite/manifests/ngf-upgrade/gateway-updated.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/ngf-upgrade/gateway.yaml b/tests/suite/manifests/ngf-upgrade/gateway.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/reconfig/gateway.yaml b/tests/suite/manifests/reconfig/gateway.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/matches.yaml b/tests/suite/manifests/scale/matches.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: listener
     port: 80
diff --git a/tests/suite/manifests/scale/upstreams.yaml b/tests/suite/manifests/scale/upstreams.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: listener
     hostname: "*.example.com"
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-1.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-1.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-10.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-10.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-11.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-11.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-12.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-12.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-13.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-13.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-14.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-14.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-15.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-15.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-16.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-16.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-17.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-17.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-18.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-18.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-19.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-19.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-2.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-2.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-20.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-20.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-21.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-21.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-22.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-22.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-23.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-23.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-24.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-24.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-25.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-25.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-3.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-3.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-4.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-4.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-5.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-5.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-6.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-6.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-7.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-7.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-8.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-8.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
diff --git a/tests/suite/manifests/scale/zero-downtime/gateway-9.yaml b/tests/suite/manifests/scale/zero-downtime/gateway-9.yaml
@@ -6,7 +6,7 @@ spec:
   gatewayClassName: nginx
   infrastructure:
     annotations:
-      service.annotations.networking.gke.io/load-balancer-type: Internal
+      networking.gke.io/load-balancer-type: Internal
   listeners:
   - name: http
     port: 80
