diff --git a/cmd/nginx-ingress/utils.go b/cmd/nginx-ingress/utils.go index 778aebd729..fe065f21e7 100644 --- a/cmd/nginx-ingress/utils.go +++ b/cmd/nginx-ingress/utils.go @@ -11,7 +11,7 @@ func getBuildInfo() (commitHash string, commitTime string, dirtyBuild string) { info, ok := debug.ReadBuildInfo() if !ok { - return + return commitHash, commitTime, dirtyBuild } for _, kv := range info.Settings { switch kv.Key { diff --git a/internal/certmanager/test_files/context_builder.go b/internal/certmanager/test_files/context_builder.go index 4407249251..4e0321f901 100644 --- a/internal/certmanager/test_files/context_builder.go +++ b/internal/certmanager/test_files/context_builder.go @@ -158,10 +158,10 @@ func (b *Builder) EnsureReactorCalled(testName string, fn coretesting.ReactionFu return func(action coretesting.Action) (handled bool, ret runtime.Object, err error) { handled, ret, err = fn(action) if !handled { - return + return handled, ret, err } b.requiredReactors[testName] = true - return + return handled, ret, err } } diff --git a/internal/certmanager/test_files/reactors.go b/internal/certmanager/test_files/reactors.go index 63aad0a006..b397642c58 100644 --- a/internal/certmanager/test_files/reactors.go +++ b/internal/certmanager/test_files/reactors.go @@ -44,7 +44,7 @@ func ObjectCreatedReactor(t *testing.T, b *Builder, expectedObj runtime.Object) return func(action coretesting.Action) (handled bool, ret runtime.Object, err error) { createAction, ok := action.(coretesting.CreateAction) if !ok { - return + return handled, ret, err } obj := createAction.GetObject() if !reflect.DeepEqual(obj, expectedObj) { @@ -60,7 +60,7 @@ func ObjectDeletedReactor(t *testing.T, b *Builder, obj runtime.Object) coretest return func(action coretesting.Action) (handled bool, ret runtime.Object, err error) { delAction, ok := action.(coretesting.DeleteAction) if !ok { - return + return handled, ret, err } namespace, name := delAction.GetNamespace(), delAction.GetName() diff --git a/internal/k8s/utils.go b/internal/k8s/utils.go index 3b8618054b..9d741136c6 100644 --- a/internal/k8s/utils.go +++ b/internal/k8s/utils.go @@ -47,7 +47,7 @@ func (s *storeToIngressLister) GetByKeySafe(key string) (ing *networking.Ingress return nil, exists, err } ing = item.(*networking.Ingress).DeepCopy() - return + return ing, exists, err } // List lists all Ingress' in the store.