Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add hugo version check and theme update to Makefile #869

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Sep 26, 2024

Proposed changes

This should help prevent any hugo or hugo-theme version drift going forward, and warn when versions are out of date.

  • Add hugo version check and theme update to Makefile
  • Update README.md with correct make target behaviors
  • Add hugo-entrypoint to allow extra commands when docker starts
  • Update hugo theme version in go.mod
  • Use slimmer hugo docker image

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@nginx-jack nginx-jack requested a review from a team as a code owner September 26, 2024 10:10
@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Sep 26, 2024
@nginx-jack nginx-jack self-assigned this Sep 26, 2024
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-agent/869/

@ADubhlaoich
Copy link
Contributor

@nginx-jack I'm a broken record at this point, but please cherry-pick for v3-documentation too!

Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
@oCHRISo oCHRISo added the v2.x Issues and Pull Requests related to the major version v2 label Sep 27, 2024
@nginx-jack nginx-jack merged commit 7087de1 into main Oct 2, 2024
38 checks passed
@nginx-jack nginx-jack deleted the docs-makefile-update branch October 2, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Improvements or additions to documentation v2.x Issues and Pull Requests related to the major version v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants