Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed make target pointing at wrong Dockerfile and renamed others to be consistent #857

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fixed make target pointing at wrong Dockerfile and renamed others to be consistent #857

merged 1 commit into from
Sep 20, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

The performance tests make target is incorrect, fixing and renaming other targets for consistency

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@oliveromahony oliveromahony requested a review from a team as a code owner September 20, 2024 13:48
@github-actions github-actions bot added the bug Something isn't working label Sep 20, 2024
@oliveromahony oliveromahony changed the title xfixed make targets, renamed some Fixed make target pointing at wrong docker and renamed others to be consistent Sep 20, 2024
@oliveromahony oliveromahony changed the title Fixed make target pointing at wrong docker and renamed others to be consistent Fixed make target pointing at wrong Dockerfile and renamed others to be consistent Sep 20, 2024
@oliveromahony oliveromahony merged commit 0d3b31d into main Sep 20, 2024
37 checks passed
@oliveromahony oliveromahony deleted the make-targets-issues branch September 20, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRashmit RRashmit RRashmit approved these changes

@aphralG aphralG aphralG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliveromahony @aphralG @RRashmit