Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds Ability To Automatically Create Symlink For NAP #85

Closed
wants to merge 2 commits into from

Conversation

wicklander-bryant
Copy link
Member

@wicklander-bryant wicklander-bryant commented Nov 1, 2022

Proposed changes

The purpose of this pull request is to allow for Agent to automatically create the necessary symlink that's required for compiled security policy bundles to be used within nginx.conf. The symlink changes depending on the specific NAP version installed.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added the bug Something isn't working label Nov 1, 2022
@wicklander-bryant wicklander-bryant changed the title fix: Adds Ability To Automatically Create Sym Link For NAP fix: Adds Ability To Automatically Create Symlink For NAP Nov 1, 2022
src/extensions/nginx-app-protect/nap/nap.go Outdated Show resolved Hide resolved
src/extensions/nginx-app-protect/nap/nap.go Outdated Show resolved Hide resolved
src/extensions/nginx-app-protect/nap/nap.go Outdated Show resolved Hide resolved
src/extensions/nginx-app-protect/nap/nap.go Outdated Show resolved Hide resolved
src/extensions/nginx-app-protect/nap/nap.go Outdated Show resolved Hide resolved
src/extensions/nginx-app-protect/nap/nap.go Outdated Show resolved Hide resolved
src/extensions/nginx-app-protect/nap/nap.go Outdated Show resolved Hide resolved
src/extensions/nginx-app-protect/nap/nap.go Show resolved Hide resolved
Copy link
Contributor

@sanathkumarbs sanathkumarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for accommodating all the changes!

@oliveromahony
Copy link
Contributor

A make deps is required to run on this branch

@oliveromahony
Copy link
Contributor

also the branch has a reference to internal jira NMS-37057 - can you santize this for external eyes?

@wicklander-bryant wicklander-bryant deleted the NMS-37057/create-nap-symlink branch November 2, 2022 21:09
@wicklander-bryant wicklander-bryant mentioned this pull request Nov 2, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants