Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade prometheus exporter version to latest #749

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Upgrade prometheus exporter version to latest #749

merged 8 commits into from
Jul 17, 2024

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Jul 16, 2024 •
edited
Loading

Proposed changes

Upgrade the prometheus exporter version to latest

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Jul 16, 2024
dhurley
dhurley approved these changes Jul 16, 2024
View reviewed changes
src/core/metrics/sources/nginx_oss.go Outdated Show resolved Hide resolved
src/core/metrics/sources/nginx_oss.go Show resolved Hide resolved
@dhurley
Copy link
Collaborator

dhurley commented Jul 17, 2024

There is a new version of nginx-plus-go-client that we should probably upgrade to as well.

@oliveromahony oliveromahony merged commit 56c58c6 into main Jul 17, 2024
28 checks passed
@oliveromahony oliveromahony deleted the upgrade-prometheus-exporter branch July 17, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@dhurley dhurley dhurley approved these changes

@olli-holmala olli-holmala Awaiting requested review from olli-holmala

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliveromahony @dhurley @aphralG