Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade crossplane version to prevent Agent from rolling back in the case of valid NGINX configurations #746

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Upgrade crossplane version to prevent Agent from rolling back in the case of valid NGINX configurations #746

merged 2 commits into from
Jul 12, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

NGINX Agent was erroring on a configuration like limit_req_zone $binary_remote_addr zone=one:10m rate=1r/s sync; and rolling back. This was a regression. Bumping the version of crossplane should alleviate this issue

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Jul 12, 2024
@oliveromahony oliveromahony changed the title Upgrade crossplane Upgrade crossplane version to prevent Agent from rolling back in the case of valid NGINX configurations Jul 12, 2024
@oliveromahony oliveromahony added highlights Highlights label to be placed in highlights section for a particular release bug Something isn't working labels Jul 12, 2024
@oliveromahony oliveromahony merged commit f7c10e4 into main Jul 12, 2024
28 checks passed
@oliveromahony oliveromahony deleted the upgrade-crossplane branch July 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@olli-holmala olli-holmala olli-holmala approved these changes

@dhurley dhurley Awaiting requested review from dhurley

@craigell craigell Awaiting requested review from craigell

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation highlights Highlights label to be placed in highlights section for a particular release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliveromahony @olli-holmala @aphralG