Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for version #732

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Fix for version #732

merged 2 commits into from
Jul 5, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

The version check was incorrect. Fixing

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the bug Something isn't working label Jul 5, 2024
@oliveromahony oliveromahony merged commit 2c39dd8 into main Jul 5, 2024
28 checks passed
@oliveromahony oliveromahony deleted the fix-for-version branch July 5, 2024 13:05
spencerugbo pushed a commit that referenced this pull request Jul 11, 2024
@oliveromahony @spencerugbo
Fix for version (#732)
b200031 
* fix version assignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell Awaiting requested review from craigell

@olli-holmala olli-holmala Awaiting requested review from olli-holmala

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliveromahony @dhurley @aphralG