Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More flexible container images for the official images #729

Merged
merged 3 commits into from
Jul 2, 2024
Merged

More flexible container images for the official images #729

merged 3 commits into from
Jul 2, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

  • Added build args NGINX_AGENT_VERSION to take different Agent versions in the official docker images.
  • Added new make target to run stable images make official-oss-stable-image and aliased make official-oss-image with make official-oss-mainline-image
  • Updated base images to use slim images

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 1, 2024
@oliveromahony oliveromahony added the chore Pull requests for routine tasks label Jul 1, 2024
nginx-nickc
nginx-nickc reviewed Jul 1, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@oliveromahony oliveromahony merged commit 4eb8f01 into main Jul 2, 2024
28 checks passed
@oliveromahony oliveromahony deleted the docker-changes branch July 2, 2024 15:15
spencerugbo pushed a commit that referenced this pull request Jul 11, 2024
@oliveromahony @spencerugbo
More flexible container images for the official images (#729)
7b1c9cb 
* updated the official docker images to accept build parameters and add override VERSION variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-nickc nginx-nickc nginx-nickc left review comments

@aphralG aphralG aphralG approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell Awaiting requested review from craigell

@olli-holmala olli-holmala Awaiting requested review from olli-holmala

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliveromahony @dhurley @aphralG @nginx-nickc