Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace duplicate isContainer call #596

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Mar 13, 2024

Proposed changes

Remove duplicate isContainer call. Needs validation against AKS
FYI @mattdesmarais

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit f73e596
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65f467088f0fc70008eea9c8
😎 Deploy Preview https://deploy-preview-596--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.94%. Comparing base (2a918fb) to head (f73e596).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   66.11%   65.94%   -0.17%     
==========================================
  Files         118      118              
  Lines       13485    13485              
==========================================
- Hits         8915     8893      -22     
- Misses       3966     3990      +24     
+ Partials      604      602       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliveromahony oliveromahony merged commit 79edf03 into main Mar 15, 2024
29 checks passed
@oliveromahony oliveromahony deleted the revert-duplicate-isContainer branch March 15, 2024 15:29
dhurley pushed a commit that referenced this pull request Mar 19, 2024
* replace duplicate isContainer call and introduce IsContainer mocking for Virtualization test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants