-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace duplicate isContainer call #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliveromahony
requested review from
dhurley,
Dean-Coakley,
craigell,
olli-holmala,
spencerugbo and
aphralG
March 13, 2024 16:30
✅ Deploy Preview for agent-public-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 66.11% 65.94% -0.17%
==========================================
Files 118 118
Lines 13485 13485
==========================================
- Hits 8915 8893 -22
- Misses 3966 3990 +24
+ Partials 604 602 -2 ☔ View full report in Codecov by Sentry. |
dhurley
approved these changes
Mar 13, 2024
aphralG
approved these changes
Mar 13, 2024
Dean-Coakley
approved these changes
Mar 14, 2024
dhurley
pushed a commit
that referenced
this pull request
Mar 19, 2024
* replace duplicate isContainer call and introduce IsContainer mocking for Virtualization test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove duplicate isContainer call. Needs validation against AKS
FYI @mattdesmarais
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)