Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move NMS agent docs #553

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: move NMS agent docs #553

merged 1 commit into from
Feb 1, 2024

Conversation

Jcahilltorre
Copy link
Contributor

Proposed changes

  • Moves some Agent docs formerly in the NMS section of the docs to the Agent product section of the docs.
  • Various Doc refinements

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit dea1b89
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65ba7ed0aace0b000830ffdd
😎 Deploy Preview https://deploy-preview-553--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation enhancement New feature or request labels Jan 31, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5efc8c2) 66.00% compared to head (dea1b89) 66.21%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   66.00%   66.21%   +0.21%     
==========================================
  Files         118      118              
  Lines       13468    13468              
==========================================
+ Hits         8889     8918      +29     
+ Misses       3979     3949      -30     
- Partials      600      601       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jcahilltorre Jcahilltorre merged commit 99260bd into main Feb 1, 2024
29 checks passed
@Jcahilltorre Jcahilltorre deleted the DOC-40B branch February 1, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants