Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for docker images #418

Merged
merged 8 commits into from
Aug 4, 2023
Merged

Add documentation for docker images #418

merged 8 commits into from
Aug 4, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Jul 24, 2023

Proposed changes

Add documentation for the following:

  • How to build a docker image with NGINX+ and NGINX Agent
  • How to build a docker image with NGINX OSS Mainline and NGINX Agent
  • How to build a docker image with NGINX OSS Stable and NGINX Agent

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 5d4978b
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64ccfd021450840008449053
😎 Deploy Preview https://deploy-preview-418--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 24, 2023
Copy link
Contributor

@Jcahilltorre Jcahilltorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with suggestions

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (3d9d248) 67.43% compared to head (5d4978b) 67.40%.
Report is 2 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   67.43%   67.40%   -0.03%     
==========================================
  Files         113      113              
  Lines       12764    12764              
==========================================
- Hits         8607     8604       -3     
- Misses       3588     3591       +3     
  Partials      569      569              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhurley dhurley self-assigned this Aug 4, 2023
@dhurley dhurley merged commit 8888428 into main Aug 4, 2023
@dhurley dhurley deleted the add-docker-image-docs branch August 4, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants