Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repair the app_protect_metadata #243

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fix: repair the app_protect_metadata #243

merged 2 commits into from
Mar 14, 2023

Conversation

edarzins
Copy link
Contributor

@edarzins edarzins commented Mar 9, 2023 •
edited by Dean-Coakley
Loading

The precompiledPublication value was not being updated in the app_protect_metadata.json file.

Proposed changes

The recent refactoring of plugins to extensions caused the updating of the app_protect_metadata.json file to be incomplete. This fixes the problem.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dhurley

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 3757bc2
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/640f3abc8ea4870008cbbcda

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Mar 9, 2023
dhurley
dhurley reviewed Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@dhurley dhurley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make install-tools & make deps?

src/plugins/nginx.go Outdated Show resolved Hide resolved
@dhurley
Copy link
Collaborator

dhurley commented Mar 10, 2023

Also looks like you need to make some updates to the nginx_test.go unit tests.

@oliveromahony
Copy link
Contributor

can you run make deps as well. If you run make install-tools it should be in your git hooks then

@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Mar 10, 2023
@edarzins
fix: repair the app_protect_metadata
a98485d 
The precompiledPublication value was not being updated in the
app_protect_metadata.json file.
@dhurley dhurley removed documentation Improvements or additions to documentation dependencies chore Pull requests for routine tasks labels Mar 13, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Mar 13, 2023
Dean-Coakley
Dean-Coakley approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as working on ubuntu:22.04.

Deps up to date.

LGTM. Thanks @edarzins !

@Dean-Coakley Dean-Coakley removed documentation Improvements or additions to documentation dependencies chore Pull requests for routine tasks labels Mar 13, 2023
@dhurley dhurley merged commit 0dbd5cf into nginx:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

@aphralG aphralG Awaiting requested review from aphralG

@craigell craigell Awaiting requested review from craigell

Assignees

@edarzins edarzins

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edarzins @dhurley @oliveromahony @Dean-Coakley