Skip to content

Commit 9149ae8

Browse files
authored
Improve metrics logging for network io and nginx workers (#16)
1 parent 855e28d commit 9149ae8

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

src/core/metrics/sources/net_io.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func (nio *NetIO) Collect(ctx context.Context, wg *sync.WaitGroup, m chan<- *pro
8787
// collect net overflow. This is not easily obtained by gopsutil, so we exec netstat to get these values
8888
overflows, err := nio.env.GetNetOverflow()
8989
if err != nil {
90-
log.Warnf("Error occurred getting network overflow metrics, %v", err)
90+
log.Debugf("Error occurred getting network overflow metrics, %v", err)
9191
}
9292

9393
if nio.netOverflows < 0 {

src/core/metrics/sources/nginx_worker.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -183,40 +183,40 @@ func (client *NginxWorkerClient) GetWorkerStats(childProcs []*proto.NginxDetails
183183

184184
pidAsInt, err := strconv.Atoi(nginxDetails.ProcessId)
185185
if err != nil {
186-
log.Warnf("failed to convert %s to int: %v", nginxDetails.ProcessId, err)
186+
log.Debugf("failed to convert %s to int: %v", nginxDetails.ProcessId, err)
187187
continue
188188
}
189189

190190
proc, err := ps.NewProcess(int32(pidAsInt))
191191
if err != nil {
192-
log.Warnf("failed to retrieve process from pid %d: %v", pidAsInt, err)
192+
log.Debugf("failed to retrieve process from pid %d: %v", pidAsInt, err)
193193
continue
194194
}
195195

196196
if times, err := proc.Times(); err == nil {
197197
usr = usr + times.User
198198
sys = sys + times.System
199199
} else {
200-
log.Warn("unable to get CPU times metrics")
200+
log.Debug("unable to get CPU times metrics")
201201
}
202202

203203
if memstat, err := proc.MemoryInfo(); err == nil {
204204
memRss += float64(memstat.RSS)
205205
memVms += float64(memstat.VMS)
206206
} else {
207-
log.Warn("unable to get memory info metrics")
207+
log.Debug("unable to get memory info metrics")
208208
}
209209

210210
if mempct, err := proc.MemoryPercent(); err == nil {
211211
memPct += float64(mempct)
212212
} else {
213-
log.Warn("unable to get memory percentage metrics")
213+
log.Debug("unable to get memory percentage metrics")
214214
}
215215

216216
if fd, err := proc.NumFDs(); err == nil {
217217
fdSum = fdSum + float64(fd)
218218
} else {
219-
log.Warn("unable to get number of file descriptors used metrics")
219+
log.Debug("unable to get number of file descriptors used metrics")
220220
}
221221

222222
if rlimit, err := proc.Rlimit(); err == nil {
@@ -228,7 +228,7 @@ func (client *NginxWorkerClient) GetWorkerStats(childProcs []*proto.NginxDetails
228228
}
229229
stats.Workers.RlimitNofile = float64(rlimitMax)
230230
} else {
231-
log.Warn("unable to get resource limit metrics")
231+
log.Debug("unable to get resource limit metrics")
232232
}
233233

234234
if ioc, err := proc.IOCounters(); err == nil {

test/performance/vendor/github.com/nginx/agent/v2/src/core/metrics/sources/net_io.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/performance/vendor/github.com/nginx/agent/v2/src/core/metrics/sources/nginx_worker.go

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)