Skip to content

projects/PeerTube: Add peertube-cli#1142

Merged
erictapen merged 3 commits into
ngi-nix:mainfrom
JuneStepp:peertube-cli
Jun 13, 2025
Merged

projects/PeerTube: Add peertube-cli#1142
erictapen merged 3 commits into
ngi-nix:mainfrom
JuneStepp:peertube-cli

Conversation

@JuneStepp
Copy link
Copy Markdown
Member

Part of ngi-nix/projects#53

The example and test aren't just called "basic", because they're merged with the service ones.

erictapen
erictapen previously approved these changes Jun 13, 2025
Copy link
Copy Markdown
Contributor

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

Comment thread projects/PeerTube/default.nix Outdated
module = ./programs/peertube-cli/module.nix;
examples.basic-cli = {
module = ./programs/peertube-cli/examples/basic.nix;
description = "CLI configuration";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tmp mhqZ6UWNpr

As this is the snippet that is going to show on the overview page, I'd like to describe what users will get from this module.

Suggested change
description = "CLI configuration";
description = "Configure peertube-cli to manage a remote Peertube instance";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erictapen random thought, how about we use the attrname of the example for a heading (the name field IIRFC is already there), and the description is shown underneath? Then maybe we can show the examples directly, i.e. without collapsing? Not sure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, the entire presentation of examples isn't really thought out yet.

@erictapen erictapen merged commit 1cb9757 into ngi-nix:main Jun 13, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Nix@NGI Jun 13, 2025
@JuneStepp JuneStepp deleted the peertube-cli branch June 13, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants