Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved places history and style issues; fill color follow-on #737

Open
justin-bits opened this issue Aug 19, 2019 · 1 comment
Open

Saved places history and style issues; fill color follow-on #737

justin-bits opened this issue Aug 19, 2019 · 1 comment

Comments

@justin-bits
Copy link
Collaborator

justin-bits commented Aug 19, 2019

  1. Border drop down doesn't show a preview of the selected border on Edit. This preview isn't visible until expanding the drop down.
  2. When editing a non-point place style via the Layers dialog, the Point/Square/Triangle drop down, Fill Style, and Border options shouldn't be available.
  3. Edit Place dialog doesn't write to history.
  4. Undo shortcut not working after changing Border. Seems to be a focus issue as the change is going into the history and undo/redo do work after changing focus to the map or some other element.
  5. Border not retained through export/import.
  6. On importing non-point saved places from a CSV, Go To zooms completely out and pans the globe away from the places.
  7. Feature actions with solid border will not override features that have a non-solid border.
@justin-bits justin-bits changed the title Saved places style issues Saved places history and style issues Aug 19, 2019
@justin-bits justin-bits changed the title Saved places history and style issues Saved places history and style issues; fill color follow-on Aug 19, 2019
@bradh
Copy link
Collaborator

bradh commented Feb 24, 2021

Also changing styles from Icon to Point/Triangle/Square doesn't get reflected in the styling used for export.

To reproduce, create a new Place, set the style to Icon and pick a recognisable icon (I used a W paddle). Then edit the Place to change it back to Point. Export the Place, and inspect the generated KML. Note the <Icon><href>https://maps.google.com/mapfiles/kml/paddle/w.png</href></Icon> or similar.

I don't yet understand the logic, but it seems like the export styling is being maintained in some kind of parallel state, and only occasionally gets updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants