Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no support for react 0.14 #226

Closed
giogonzo opened this issue Jan 17, 2017 · 3 comments
Closed

no support for react 0.14 #226

giogonzo opened this issue Jan 17, 2017 · 3 comments

Comments

@giogonzo
Copy link

Hi there, with this commit support for react 0.14 is gone (see e.g. facebook/react#5355)

Which is fine, but not if released as a "patch" version I'd say? 😇

Also I don't see any peerDependencies on react >= 15, is this deliberate?
@cwelch5
Copy link
Contributor

cwelch5 commented Jan 17, 2017

Thanks @giogonzo for looking out. I reverted just the NullComponent portion and tested with React 0.14.8. I marked 3.3.1 as broken and bumped to 3.3.2. I kept peerDependencies omitted for now. I will add back in a future release.

@cwelch5 cwelch5 closed this as completed Jan 17, 2017
@cwelch5
Copy link
Contributor

cwelch5 commented Jan 17, 2017

Published Helmet v4.0.0 with a requirement for React 15. Thanks.

@giogonzo
Copy link
Author

Thank you for the fast turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwelch5 @giogonzo