Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change oras with https for singularity #111

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

kubranarci
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@kubranarci kubranarci linked an issue Nov 25, 2024 that may be closed by this pull request
@nf-core-bot
Copy link
Member

⚠️ Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, there's another local module modules/local/vcf_to_csv/main.nf that also uses oras://. Could this be changed as well?

@@ -4,7 +4,7 @@ process VARIANT_EXTRACTOR {

conda "${moduleDir}/environment.yml"
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'oras://community.wave.seqera.io/library/htslib_pysam_tabix_pip_variant-extractor:a12ef217eccf6ba8':
'https://community.wave.seqera.io/library/htslib_pysam_tabix_pip_variant-extractor:a12ef217eccf6ba8':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the correct adress.

singularity pull https://community.wave.seqera.io/library/htslib_pysam_tabix_pip_variant-extractor:a12ef217eccf6ba8
WARNING: Authentication token file not found : Only pulls of public images will succeed
FATAL:   The requested image was not found in the library

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, I think it is not possible to convert oras to https for wave containers. I have been checking https://seqera.io/containers/
Screenshot 2024-11-28 at 15 27 22

and found out this.

Do you have another idea to create mulled images other than seqera containers?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to check a HTTPS box when building.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the link! new singularity images are working for me now. Can you please review it again? Thanks

tests/.nftignore Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these changed in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicting with my previous merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't download singularity containers for modules with oras://
3 participants