Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail linting if md5sum for empty files are found in a stub test #2571

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

mirpedrol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mirpedrol mirpedrol requested a review from mashehu December 12, 2023 08:57
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🎉

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e62d113) 75.04% compared to head (40ee3b2) 74.96%.
Report is 1 commits behind head on dev.

Files Patch % Lines
nf_core/modules/lint/module_tests.py 53.33% 7 Missing ⚠️
nf_core/subworkflows/lint/subworkflow_tests.py 53.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2571      +/-   ##
==========================================
- Coverage   75.04%   74.96%   -0.09%     
==========================================
  Files          85       85              
  Lines        9288     9306      +18     
==========================================
+ Hits         6970     6976       +6     
- Misses       2318     2330      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit cb787dd into nf-core:dev Dec 14, 2023
20 checks passed
@mirpedrol mirpedrol deleted the empty-file-stub branch December 14, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants