Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation for module test.yml changed after v2.5.1 release #1866

Closed
drpatelh opened this issue Oct 4, 2022 · 3 comments
Closed

Indentation for module test.yml changed after v2.5.1 release #1866

drpatelh opened this issue Oct 4, 2022 · 3 comments
Labels
bug Something isn't working high-priority
Milestone

Comments

@drpatelh
Copy link
Member

drpatelh commented Oct 4, 2022

Description of the bug

Running nf-core modules create-test-yml the indentation has been removed whenever a line begins with -.

Old format

- name: samtools index test_samtools_index_bai
  command: nextflow run ./tests/modules/nf-core/samtools/index -entry test_samtools_index_bai -c ./tests/config/nextflow.config -c ./tests/modules/nf-core/samtools/index/nextflow.config
  tags:
    - samtools
    - samtools/index
  files:
    - path: output/samtools/test.paired_end.sorted.bam.bai
      md5sum: 704c10dd1326482448ca3073fdebc2f4

New format

- name: samtools index test_samtools_index_bai
  command: nextflow run ./tests/modules/nf-core/samtools/index -entry test_samtools_index_bai -c ./tests/config/nextflow.config -c ./tests/modules/nf-core/samtools/index/nextflow.config
  tags:
  - samtools
  - samtools/index
  files:
  - path: output/samtools/test.paired_end.sorted.bam.bai
    md5sum: 704c10dd1326482448ca3073fdebc2f4

Command used and terminal output

No response

System information

No response

@drpatelh drpatelh added bug Something isn't working high-priority labels Oct 4, 2022
@ewels
Copy link
Member

ewels commented Nov 29, 2022

All that should matter is that prettier is happier, right? As long as the syntax is the same? This should be forced via the run_prettier_on_file function that we have.

Then parsed syntax of these two examples is identical (try converting to JSON, it gives the same output).

Can you clarify what the problem is here @drpatelh ?

@ewels
Copy link
Member

ewels commented Nov 29, 2022

This should be forced via the run_prettier_on_file function that we have.

@mashehu not sure that it does this actually. So maybe we can check that and add if not.

@ewels ewels added this to the 2.7 milestone Nov 29, 2022
@mirpedrol
Copy link
Member

Fixed by #2078 2078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

3 participants