Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong yamllint config #1413

Closed
mashehu opened this issue Feb 16, 2022 · 5 comments
Closed

wrong yamllint config #1413

mashehu opened this issue Feb 16, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@mashehu
Copy link
Contributor

mashehu commented Feb 16, 2022

Description of the bug

It looks like yamllint.yml is not recognized by the npm-version of yamllint (#1412 (comment)), which is the one the github action uses.

So, we either can use a different yaml-lint config or we switch to a different yamllint in the github action, e.g. this one seems to be based on the yamllint we wrote the yamllint.yml for (and have installed in the gitpod image) https://github.com/marketplace/actions/yamllint-github-action

Command used and terminal output

No response

System information

No response

@mashehu mashehu added the bug Something isn't working label Feb 16, 2022
@JoseEspinosa
Copy link
Member

After some try and error, I think the best will be to switch to the GitHub action you proposed above, I will try to draft a PR as soon as I can

@ewels
Copy link
Member

ewels commented Feb 19, 2022

I think we've talked about using Prettier before to consolidate markdown and YAML into one tool. Maybe now would be a good time?

@mashehu
Copy link
Contributor Author

mashehu commented Feb 21, 2022

I looked a bit into switching to prettier over the weekend. I think we should stick with markdown-lint and yaml-lint for now, because most of our markdown rules (e.g. ul-indent,no-duplicate-header, etc.) can not be replicated in a prettier config as far as I can see. But if you say these rules are not that important we could switch.

@JoseEspinosa
Copy link
Member

Tried to fix this issue here #1422

@JoseEspinosa
Copy link
Member

In the PR above, I switch to the github action proposed by @mashehu, might have lost some discussion since I could not connect last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants