Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to restrict analysis to specific contigs #644

Merged
merged 11 commits into from
Nov 11, 2024
Merged

Add option to restrict analysis to specific contigs #644

merged 11 commits into from
Nov 11, 2024

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c98d063

+| ✅ 201 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_dark.png
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-11 21:02:42

@ramprasadn ramprasadn marked this pull request as ready for review November 9, 2024 09:13
@fellen31
Copy link
Contributor

In long-reads I imagine this strategy would not call translocations with one good breakpoint in an interesting gene on 1-22, X, Y and the other breakpoint mapping to a few different places (including unplaced contigs).

Would this be an issue here?

@ramprasadn
Copy link
Collaborator Author

Hi Felix! We have added the option to restrict the analysis to chromosomes only because alignments to unplaced contigs can be messy, leading to less reliable results. We want to minimize any potential errors from those alignments.

fellen31
fellen31 reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add to the usage documentation?

Otherwise it looks good to me. I'd lean towards using a BED-file rather than a regions string, but both work.

@fellen31
Copy link
Contributor

Hi Felix! We have added the option to restrict the analysis to chromosomes only because alignments to unplaced contigs can be messy, leading to less reliable results. We want to minimize any potential errors from those alignments.

Makes sense to not deal with such variants at all, thanks for clarifying!

@ramprasadn ramprasadn requested a review from fellen31 November 11, 2024 14:00
fellen31
fellen31 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jemten
jemten approved these changes Nov 11, 2024
View reviewed changes
subworkflows/local/alignment/align_bwa_bwamem2_bwameme.nf Outdated Show resolved Hide resolved
subworkflows/local/alignment/align_sentieon.nf Outdated Show resolved Hide resolved
@ramprasadn ramprasadn merged commit afea4ff into dev Nov 11, 2024
7 checks passed
@jemten jemten deleted the samtools_view branch November 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fellen31 fellen31 fellen31 approved these changes

@jemten jemten jemten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadn @fellen31 @jemten